Add now-passing test for #3133 #4231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowtowncoder
approved these changes
Nov 28, 2023
|
Thank you @JooHyukKim ! |
pjfanning
reviewed
Nov 28, 2023
| // case 1 : type first | ||
| String ordering1 = a2q("{'type': 'MAP','map': { 'doubleValue': 0.1 }}"); | ||
| TestMapContainer model1 = mapper.readValue(ordering1, TestMapContainer.class); | ||
| Assertions.assertTrue(model1.getMap().get("doubleValue") instanceof Double); |
There was a problem hiding this comment.
I think this would be better as assertEquals(0.1d, model1.getMap().get("doubleValue"))
There was a problem hiding this comment.
At that time, I was unsure whether to closely align with the test case from #3133.
In hindsight, I should've gone with your suggestion. Thankss 🙏🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addes a test case proving #3133 is fixed for at least Jackson 2.15 or later version.